Project

General

Profile

Actions

Bug #1178

open

Unknown term definition is not saved

Added by Miroslav Blaško over 4 years ago. Updated over 4 years ago.

Status:
New
Priority:
Low
Target version:
-
Start date:
06.04.2020
Due date:
% Done:

0%

Estimated time:

Description

When I annotate unknown term definition and then navigate somewhere else, the definition is not saved.

Way to reproduce:
1) Open MPP-3.5 file content https://kbss.felk.cvut.cz/termit-dev/#/resources/file/annotate?namespace=http://onto.fel.cvut.cz/ontologies/slovn%C3%ADk/datov%C3%BD/mpp-3.5-np/document/
2) Mark term definition "zástavby a krajiny ve městě a v neposlední řadě"
3) Issue 1: After "Mark term definition" is hit, selection is switched as shown in picture "Issue 2" from attachment
4) Click the close button on annotation pop-up
5) Issue 2: Pop-up with options to annotate is shown for again for the selection mentioned in 3)
6) "Unknown term definition" is now visualized correctly as shown in the attachment as "Step 6"
7) Navigate somewhere else in UI (e.g. Resources)
8) Navigate back to https://kbss.felk.cvut.cz/termit-dev/#/resources/file/annotate?namespace=http://onto.fel.cvut.cz/ontologies/slovn%C3%ADk/datov%C3%BD/mpp-3.5-np/document/
9) Issue 3: Marked term definition is lost !!!

Acceptance criteria:
  1. Resolve Issue 3

Issues 1 and 2 are not that critical so I decided to not put it into redmine. If you did not manage to fix it and you consider it otherwise, please put it to redmine (Just copy steps to reproduce).


Files

Actions #2

Updated by Miroslav Blaško over 4 years ago

  • Description updated (diff)
Actions #3

Updated by Petr Křemen over 4 years ago

  • Target version set to 2.0.0
  • Priority changed from Normal to Low

to be discussed in a week based on the capacities and progress

Actions #4

Updated by Miroslav Blaško over 4 years ago

According to Martin: It works the same way as "occurrences of unknown terms". Sorry, I misunderstood it first, but now I recall and I agree that the resolution of this task is not important to this milestone at all even if we have somebody annotating a lot of data.

To describe as I understand it:
There are two kinds of annotations "significant" and "insignificant". "Insignificant" annotations are "annotation of the unknown term" and now also "source of the definition of unknown term", while "significant" ones are all the others. Insignificant annotations are not saved by themself, but they are saved whenever "significant" annotation is saved.

It is a little less intuitive but I remember the rationale behind that. Annotator used to have way of creating "annotation of the unknown term" just by simple selection of text (no more additional clicks). This was suited for a use-case in my mind (never confirmed that it is useful for somebody else but me) where the user first marks down all the occurrences and later specifies concrete terms related to those occurrences. Marking those occurrences were super-fast since "insignificant" changes were not saved (no need to save again full HTML).

Actions #5

Updated by Petr Křemen over 4 years ago

  • Target version deleted (2.0.0)
  • Assignee set to Miroslav Blaško
Actions

Also available in: Atom PDF